Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): Accommodate larger screens on dashboards overview #78719

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nikkikapadia
Copy link
Member

@nikkikapadia nikkikapadia commented Oct 7, 2024

Allows for more than three cards in a row on the dashboards overview on larger screens. Also allows for as many dashboards needed to fill the page to be previewed instead of 9.

before:

image

after:

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2024
@nikkikapadia nikkikapadia marked this pull request as ready for review October 8, 2024 13:40
@nikkikapadia nikkikapadia requested a review from a team as a code owner October 8, 2024 13:40
@nikkikapadia nikkikapadia marked this pull request as draft October 8, 2024 14:12
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/dashboards/manage/index.tsx 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78719      +/-   ##
==========================================
+ Coverage   78.21%   78.24%   +0.02%     
==========================================
  Files        7104     7107       +3     
  Lines      312956   313078     +122     
  Branches    51106    51109       +3     
==========================================
+ Hits       244790   244958     +168     
+ Misses      61805    61760      -45     
+ Partials     6361     6360       -1     

@nikkikapadia nikkikapadia marked this pull request as ready for review October 8, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant