feat(issue-stream): Update priority badge/selector #78726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
commented
Oct 7, 2024
Comment on lines
99
to
105
| label: ( | ||
| <GroupPriorityBadge | ||
| variant={hasStreamlinedIssueStream ? 'streamlined' : 'default'} | ||
| priority={priority} | ||
| /> | ||
| ), |
There was a problem hiding this comment.
Note that I have decided to keep the labels for the badges that are shown in the dropdown, unlike for the badges in the issue stream.
MichaelSun48
commented
Oct 7, 2024
| interface Props extends SVGIconProps { | ||
| bars?: 0 | 1 | 2 | 3; | ||
| } | ||
| const IconCellSignal = forwardRef<SVGSVGElement, Props>(({bars = 3, ...props}, ref) => { |
There was a problem hiding this comment.
Not attached to this name, feel free to give suggestions.
There was a problem hiding this comment.
Looks like material icons has a similar name, so seems okay to me.
Only other think I could think of would be IconSignalBars
MichaelSun48
commented
Oct 7, 2024
malwilley
reviewed
Oct 8, 2024
| type={variant === 'signal' ? 'default' : getTagTypeForPriority(priority)} | ||
| icon={variant === 'signal' && <IconCellSignal bars={bars} />} | ||
| > | ||
| {(showLabel && PRIORITY_KEY_TO_LABEL[priority]) ?? t('Unknown')} |
There was a problem hiding this comment.
Can you use VisuallyHidden here so that the text still exists for screen readers and tests?
malwilley
approved these changes
Oct 8, 2024
MichaelSun48
force-pushed
the
msun/issuesTable/updateGroupPrioritySelector
branch
from
60d6679
to
9bf00de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77819
Creates the new design for the issue priority badge under the
variantprop within the<GroupPriorityBadge/>component. This design is currently under a feature flag, so it is not visible.Demo with flag manually set to true:
Screen.Recording.2024-10-07.at.1.47.39.PM.mov