Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboards): Remove usage of query builder feature flags #78773

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Oct 8, 2024

Post-GA cleanup. Removing the flag, updating the specs to target the query builder.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #78773   +/-   ##
=======================================
  Coverage   78.25%   78.26%           
=======================================
  Files        7105     7105           
  Lines      313224   313214   -10     
  Branches    51135    51133    -2     
=======================================
+ Hits       245110   245127   +17     
+ Misses      61752    61722   -30     
- Partials     6362     6365    +3     

This is required now, because the query builder for events checks that
flag when creating the tag suggestion dropdowns.
@gggritso gggritso marked this pull request as ready for review October 8, 2024 19:59
@gggritso gggritso requested a review from a team as a code owner October 8, 2024 19:59
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Love seeing all those deleted lines 💯

await userEvent.click(
await screen.findByRole('combobox', {name: 'Add a search term'})
);
await userEvent.paste('ass');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫏

@gggritso gggritso merged commit afcaad4 into master Oct 8, 2024
54 checks passed
@gggritso gggritso deleted the chore/dashboards/remove-query-builder-flags branch October 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants