Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jira): Makes team an autofill field in integration forms #78777

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

GabeVillalobos
Copy link
Member

@GabeVillalobos GabeVillalobos commented Oct 8, 2024

Makes the Team field an autofillable field.

Currently, selecting a team is a painful experience. It requires manually looking up and pasting the team UUID into the UI:
image

Even with the UI error fixes we've made recently, the errors for entering an incorrect team ID results in a vague, non-descriptive error.

Making team a queryable field similar to user selection removes this problem entirely, disallowing a user from selecting an invalid team:
image

This PR also adds error handling for team errors to show an explicit error for previously configured alerts:
image

@GabeVillalobos GabeVillalobos requested review from a team as code owners October 8, 2024 17:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/jira/integration.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78777      +/-   ##
==========================================
- Coverage   78.25%   78.25%   -0.01%     
==========================================
  Files        7105     7105              
  Lines      313203   313215      +12     
  Branches    51132    51137       +5     
==========================================
- Hits       245106   245100       -6     
- Misses      61734    61754      +20     
+ Partials     6363     6361       -2     

@GabeVillalobos GabeVillalobos merged commit 2f0513d into master Oct 8, 2024
49 of 50 checks passed
@GabeVillalobos GabeVillalobos deleted the gv/make-team-ui-more-usable branch October 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants