Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): Accept timeout customization in uptime APIs #78788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanpurkhiser
Copy link
Member

Requires #78787
Requires #78782

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 8, 2024 19:54
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Oct 8, 2024

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
29760 7 29753 216
View the top 3 failed tests by shortest run time
tests.sentry.uptime.detectors.test_tasks.ProcessCandidateUrlTest test_succeeds_existing_subscription_this_project
Stack Traces | 3.43s run time
#x1B[1m#x1B[.../uptime/detectors/test_tasks.py#x1B[0m:250: in test_succeeds_existing_subscription_this_project
    assert process_candidate_url(self.project, 100, url, 50)
#x1B[1m#x1B[.../uptime/detectors/tasks.py#x1B[0m:222: in process_candidate_url
    monitor_url_for_project(project, url)
#x1B[1m#x1B[.../uptime/detectors/tasks.py#x1B[0m:245: in monitor_url_for_project
    get_or_create_project_uptime_subscription(
#x1B[1m#x1B[31mE   TypeError: get_or_create_project_uptime_subscription() missing 1 required positional argument: 'timeout_ms'#x1B[0m
tests.sentry.uptime.detectors.test_tasks.ProcessCandidateUrlTest test_succeeds_new
Stack Traces | 3.45s run time
#x1B[1m#x1B[.../uptime/detectors/test_tasks.py#x1B[0m:217: in test_succeeds_new
    assert process_candidate_url(self.project, 100, url, 50)
#x1B[1m#x1B[.../uptime/detectors/tasks.py#x1B[0m:222: in process_candidate_url
    monitor_url_for_project(project, url)
#x1B[1m#x1B[.../uptime/detectors/tasks.py#x1B[0m:245: in monitor_url_for_project
    get_or_create_project_uptime_subscription(
#x1B[1m#x1B[31mE   TypeError: get_or_create_project_uptime_subscription() missing 1 required positional argument: 'timeout_ms'#x1B[0m
tests.sentry.uptime.detectors.test_tasks.TestMonitorUrlForProject test_existing
Stack Traces | 3.56s run time
#x1B[1m#x1B[.../uptime/detectors/test_tasks.py#x1B[0m:342: in test_existing
    monitor_url_for_project(self.project, url)
#x1B[1m#x1B[.../uptime/detectors/tasks.py#x1B[0m:245: in monitor_url_for_project
    get_or_create_project_uptime_subscription(
#x1B[1m#x1B[31mE   TypeError: get_or_create_project_uptime_subscription() missing 1 required positional argument: 'timeout_ms'#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@@ -27,7 +27,7 @@ interface Props {
}

export function DetailsTimeline({monitor, organization}: Props) {
const {location} = useRouter();
const location = useLocation();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants