fix(grouping): Fix FallbackVariant.description
property
#78833
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we calculate event grouping, we generate instances of various
BaseVariant
subclasses. Probably the most common variant isComponentVariant
, which is a hierarchical structure consisting of nestedGroupingComponent
s. Both variants and components identify themselves using adescription
attribute, which variants base on theirtype
and components base on theirid
.A much less common variant is the
FallbackVariant
, which we use when we don't have enough data for any of the other grouping methods to work. Perhaps its rarity (combined with the infrequency with which people pay close attention to grouping info data) explains why we've never noticed this, but fallback variants have anid
(as if they were components) rather than atype
(as they should as variants). As a result, their description isNone
rather than a real, useful value.This fixes that by switching the attribute name from
id
totype
.