Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grouping): Fix FallbackVariant.description property #78833

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

When we calculate event grouping, we generate instances of various BaseVariant subclasses. Probably the most common variant is ComponentVariant, which is a hierarchical structure consisting of nested GroupingComponents. Both variants and components identify themselves using a description attribute, which variants base on their type and components base on their id.

A much less common variant is the FallbackVariant, which we use when we don't have enough data for any of the other grouping methods to work. Perhaps its rarity (combined with the infrequency with which people pay close attention to grouping info data) explains why we've never noticed this, but fallback variants have an id (as if they were components) rather than a type (as they should as variants). As a result, their description is None rather than a real, useful value.

This fixes that by switching the attribute name from id to type.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant