add command unset #1475
Merged
add command unset #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duthils
force-pushed
the
unset-command
branch
2 times, most recently
from
213e477
to
6743394
Compare
|
The test failure was due to using the same file |
|
@felixfontein Any update on this? Would love this functionality. |
felixfontein
approved these changes
Jun 23, 2024
|
@duthils Good to merge? I'm planning on using this functionality shortly. Thanks for the change! |
|
@HarshSheth1128 Yes, good to merge, I have rebased the branch to avoid conflicts upon merge. |
Signed-off-by: Sebastien Duthil <duthils@duthils.net>
Signed-off-by: Sebastien Duthil <duthils@duthils.net>
Signed-off-by: Sebastien Duthil <duthils@duthils.net>
felixfontein
force-pushed
the
unset-command
branch
from
4bf37e3
to
2d914d2
Compare
|
@duthils thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
unsetcommand to remove a key or item from the file.Fixes #1305.
I'm not familiar with Go or Rust, so I mainly adapted what was already present in the
setcommand.