Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gobinding] add more methods to context interface #2349

Closed
hsinhoyeh opened this issue Aug 13, 2024 · 1 comment · Fixed by #2350
Closed

[gobinding] add more methods to context interface #2349

hsinhoyeh opened this issue Aug 13, 2024 · 1 comment · Fixed by #2350

Comments

@hsinhoyeh
Copy link
Contributor

Hi there,

I am using go binding for whisper and want to add some functions in context interface

+       SetMaxContext(n int)            // Set maximum number of text context tokens to store
+       SetBeamSize(n int)              // Set Beam Size
+       SetEntropyThold(t float32)      // Set Entropy threshold

just wondering what is the best way to keep it in sync or we just update it manually?

@hsinhoyeh
Copy link
Contributor Author

just fire a PR first, and see if we have better idea (or more functions to add).

iThalay pushed a commit to iThalay/whisper.cpp that referenced this issue Sep 23, 2024
…anov#2350)

* feat(go binding): add beamsize/entropythold/maxcontext to context interface

fixes: ggerganov#2349

* fix go building build

* fix dynamic link .so and header.h

* remove LD_LIBRARY_PATH

* remove ggml obj from whisper dynamic lib

* drop LIB_GGML
iThalay pushed a commit to iThalay/whisper.cpp that referenced this issue Sep 23, 2024
…anov#2350)

* feat(go binding): add beamsize/entropythold/maxcontext to context interface

fixes: ggerganov#2349

* fix go building build

* fix dynamic link .so and header.h

* remove LD_LIBRARY_PATH

* remove ggml obj from whisper dynamic lib

* drop LIB_GGML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant