Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short voice be skipped in speed_up mode #405

Closed
glcolor opened this issue Jan 14, 2023 · 0 comments
Closed

Short voice be skipped in speed_up mode #405

glcolor opened this issue Jan 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@glcolor
Copy link

glcolor commented Jan 14, 2023

In line 2876 of whiper.cpp, this code will skip some short voice segments incorrectly when speed_up is true. Should the 100 samples here be changed to a smaller value when speed_up is true, such as 50?

// if length of spectrogram is less than 1s (100 samples), then return
// basically don't process anything that is less than 1s
// see issue #39: https://github.com/ggerganov/whisper.cpp/issues/39
if (seek_end < 100 + seek_start) {
    return 0;
}
@ggerganov ggerganov added the bug Something isn't working label Jan 15, 2023
rock3125 pushed a commit to rock3125/whisper.cpp that referenced this issue Feb 21, 2023
anandijain pushed a commit to anandijain/whisper.cpp that referenced this issue Apr 28, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this issue Oct 24, 2023
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this issue Oct 24, 2023
landtanin pushed a commit to landtanin/whisper.cpp that referenced this issue Dec 16, 2023
iThalay pushed a commit to iThalay/whisper.cpp that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants