whisper: Use emplace_back in place of push_back #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids potential construction of temporaries.
|
@asmaloney Thanks for the contributions! |
|
My pleasure. Thank you for the project! I'm having fun playing with it. I probably won't have any deep contributions since I don't understand the details, but I'm happy to do some little things. I think it's an important project because it lets people embed this tech into projects that otherwise don't have easy access to it (because... Python). I can imagine lots of accessibility scenarios where it could be used to help people who have problems with fine motor skills. And with your other language bindings it really opens it up! (e.g. I use go a lot.) Have a great xmas weekend! 🎄 |
rock3125
pushed a commit
to rock3125/whisper.cpp
that referenced
this pull request
Feb 21, 2023
This avoids potential construction of temporaries.
anandijain
pushed a commit
to anandijain/whisper.cpp
that referenced
this pull request
Apr 28, 2023
This avoids potential construction of temporaries.
jacobwu-b
pushed a commit
to jacobwu-b/Transcriptify-by-whisper.cpp
that referenced
this pull request
Oct 24, 2023
This avoids potential construction of temporaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids potential construction of temporaries.