Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add registerServices in Grid Options #1

Merged
merged 9 commits into from
Jun 2, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 29, 2020

  • the "registerServices" can accept an array of Services to register, this could be used by the user when he wants to load External Services like ExcelExportService, FileExportService, ...

  • also add DataView and SlickGrid interfaces

  • See Migration for new usage

TODO

  • add a new registeringExternalServices method to handle Export Services
  • remove any arguments from the registering service constructors
  • add a bypass for Salesforce use of CSV Export without the need of registering the service
  • add unit tests
  • should we move export options into the registering service constructor?

- the "registerServices" can accept an array of Services to register, this could be used by the user when he wants to load External Services like ExcelExportService, FileExportService, ...
- also add DataView interface
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1 into master will increase coverage by 0.07%.
The diff coverage is 84.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   94.71%   94.77%   +0.07%     
==========================================
  Files         172      171       -1     
  Lines        8510     8554      +44     
  Branches     2880     2817      -63     
==========================================
+ Hits         8059     8106      +47     
+ Misses        451      448       -3     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/checkboxEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <ø> (ø)
packages/common/src/editors/textEditor.ts 100.00% <ø> (ø)
...ages/common/src/extensions/autoTooltipExtension.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917f044...e2660c9. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(services): add registerServices in Grid Options feat(services): add registerServices in Grid Options Jun 2, 2020
@ghiscoding ghiscoding merged commit e7c2e91 into master Jun 2, 2020
@ghiscoding ghiscoding deleted the feat/register-services branch June 2, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants