Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): clear dataset when disposing and fix few unsubscribed events to avoid leak #156

Merged
merged 18 commits into from
Nov 12, 2020
Merged

fix(core): clear dataset when disposing and fix few unsubscribed events to avoid leak #156

merged 18 commits into from
Nov 12, 2020

Commits on Nov 10, 2020

  1. fix(core): do not keep dataset local copy avoid leak when disposing

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    8947aff View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. refactor: tweak code to avoid mem leaks

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    87d8685 View commit details
    Browse the repository at this point in the history

  2. refactor: rebuild slick vanilla bundle zip file

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    467004a View commit details
    Browse the repository at this point in the history

  3. refactor: rollback changes in grid event service 

    - better to use anonymous functions when subscribing
    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    2bcaa81 View commit details
    Browse the repository at this point in the history

  4. refactor: rebuild slick vanilla bundle zip file

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    0a1c977 View commit details
    Browse the repository at this point in the history

  5. refactor: add optional boolean argument to slick grid destroy fn 

    - when the boolean is set to true it will destroy all dom elements to avoid mem leaks
    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1fe103c View commit details
    Browse the repository at this point in the history

  6. refactor: re-arrange private methods

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    a1eedf0 View commit details
    Browse the repository at this point in the history

  7. fix: add unbindAll to BindingService to avoid detached events

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    d7a74b8 View commit details
    Browse the repository at this point in the history

  8. fix(filters): any Filter should only trigger search callback once 

    - some Filters have multiple events attached to the elements and in some cases it was calling multiple search filtering execution
    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    3b9ae24 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. refactor: properly remove event listener in all examples

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    46da59f View commit details
    Browse the repository at this point in the history

  2. fix: make sure to remove every event listeners when disposing

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    57cf64e View commit details
    Browse the repository at this point in the history

  3. refactor: fix linter warnings

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9d0a43e View commit details
    Browse the repository at this point in the history

  4. refactor: add slick dataview optional destroy method

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    30d12c4 View commit details
    Browse the repository at this point in the history

  5. refactor: dispose of the renderer events only after the vm is disposed

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    05a6356 View commit details
    Browse the repository at this point in the history

  6. refactor: fix failing unit test

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    181d20f View commit details
    Browse the repository at this point in the history

  7. refactor: rebuild slick vanilla bundle zip and disable empty warning msg

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    88227d5 View commit details
    Browse the repository at this point in the history

  8. refactor: add missing unit test

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6aef1be View commit details
    Browse the repository at this point in the history

  9. refactor: add full unit test coverage

    Ghislain Beaulac authored and Ghislain Beaulac committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    1df2788 View commit details
    Browse the repository at this point in the history