Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): filtering with IN_CONTAINS should also work with spaces #368

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 2, 2021

  • fixes a bug reported in SlickGrid issue 611

with the fix, it now returns the correct rows in the grid, but without the fix this was returning nothing

image

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #368 (ab54724) into master (4b979dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #368   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          213       213           
  Lines        13062     13062           
  Branches      4276      4276           
=========================================
  Hits         13062     13062           
Impacted Files Coverage Δ
...es/common/src/filter-conditions/filterUtilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b979dd...ab54724. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit fbab810 into master Jun 2, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/filter-in-contains-trim-spaces branch June 2, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants