Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): using initiallyCollapsed change internal toggled state #380

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

ghiscoding
Copy link
Owner

  • if we defined initiallyCollapsed as true, we should expect the internal toggle state change to be updated accordingly
  • also add extra arguments to the applyToggledItemStateChanges() method to skip a full toggle and also another argument to optionally trigger an item toggled event

- if we defined `initiallyCollapsed` as true, we should expect the internal toggle state change to be updated accordingly
- also add extra arguments to the `applyToggledItemStateChanges()` method to skip a full toggle and also another argument to optionally trigger an item toggled event
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #380 (bf1faec) into master (ec974ca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #380   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          216       216           
  Lines        13188     13198   +10     
  Branches      4312      4317    +5     
=========================================
+ Hits         13188     13198   +10     
Impacted Files Coverage Δ
packages/common/src/services/treeData.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec974ca...bf1faec. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit d2e5685 into master Jun 14, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/tree-data-init-state branch June 14, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants