Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add Composite Editor modal dialog #76

Merged
merged 71 commits into from
Sep 15, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 15, 2020

  • Composite Editor reuses the grid editors from the column definitions and present them all into a single form displayed in a modal dialog window, it also carries the editor validators and everything else.

Feature

Quick recap, this PR adds the following 4 options all available via a Composite Editor Modal, it allows to do:

  1. Create New Item
  2. Edit Current Item (active cell/row)
  3. Mass Update Changes
  4. Mass Selection Changes (on Selected Rows)

TODOs

  • add POC
  • add full implementation
  • create necessary PR in SlickGrid core lib PR #530 and get it merged
  • add Jest full unit test suite
  • add Cypress E2E full test suite

image

- Composite Editor reuses the grid editors from the column definitions and present them all into a single form displayed in a modal dialog window, it also carries the editor validators and everything else.
- Composite Editor reuses the grid editors from the column definitions and present them all into a single form displayed in a modal dialog window, it also carries the editor validators and everything else.
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #76    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          193       195     +2     
  Lines        10268     11147   +879     
  Branches      3366      3634   +268     
==========================================
+ Hits         10268     11147   +879     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <ø> (ø)
packages/common/src/enums/fieldType.enum.ts 100.00% <ø> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <ø> (ø)
packages/common/src/filters/autoCompleteFilter.ts 100.00% <ø> (ø)
packages/common/src/filters/filters.index.ts 100.00% <ø> (ø)
...la-bundle/src/components/slick-footer.component.ts 100.00% <ø> (ø)
...ages/common/src/editorValidators/floatValidator.ts 100.00% <100.00%> (ø)
...es/common/src/editorValidators/integerValidator.ts 100.00% <100.00%> (ø)
...ges/common/src/editorValidators/sliderValidator.ts 100.00% <100.00%> (ø)
...kages/common/src/editorValidators/textValidator.ts 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bead2fe...3d6be99. Read the comment docs.

ghiscoding-SE and others added 27 commits September 8, 2020 20:57
@ghiscoding ghiscoding changed the title WIP - feat(editor): add Composite Editor modal dialog feat(editor): add Composite Editor modal dialog Sep 15, 2020
@ghiscoding ghiscoding merged commit bba0b80 into master Sep 15, 2020
@ghiscoding ghiscoding deleted the feat/composite-editor branch September 15, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants