Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of MA_RESERVED1 breaks on recent Solaris builds #1002

Closed
dhduvall opened this issue Mar 28, 2017 · 3 comments · Fixed by #1003
Closed

Use of MA_RESERVED1 breaks on recent Solaris builds #1002

dhduvall opened this issue Mar 28, 2017 · 3 comments · Fixed by #1003
Labels
bug sunos

Comments

@dhduvall
Copy link
Contributor

dhduvall commented Mar 28, 2017 •
edited
Loading

This is against internal-to-Oracle Solaris, but recently MA_RESERVED1 was renamed to MA_CORE_NODATA, as that value was given a specific use. Currently, psutil translates that flag to *, but I can't find any documentation on what that's supposed to mean. The documentation for the perms field in /proc/pid/maps in proc(5) only talks about r, w, x, s, and p, and not R and * as are also used in _psutil_sunos.c. Since MA_RESERVED1 was never used for anything (at least, not in recent memory), it's not clear that the * meant anything either, and it probably should just be dropped. I can whip up a pull request for that, if desired.
@giampaolo
Copy link
Owner

What are you talking about? lol

@dhduvall
Copy link
Contributor Author

_psutil_sunos.c references the macro MA_RESERVED1, which is going away in the next release of Solaris (and has already gone away in our internal builds). The symbol it maps to isn't, to my knowledge, documented anywhere with any meaning, and I wanted to be sure of that before submitting a pull request to remove the reference to that macro.

@giampaolo
Copy link
Owner

Oh I get it now. Yeah, I think you can freely remove both "R" and "*". I don't remember where I got that from.

dhduvall pushed a commit to dhduvall/psutil that referenced this issue Mar 28, 2017
remove use of MA_RESERVED1 from SunOS module
6a2c351 
MA_RESERVED1 never meant anything, and the macro is going away in the
next release of Solaris.  MA_NORESERVE wasn't really mapped to anything
useful, either.  Removing the use of both macros shouldn't make any
material difference, and will be compatible across more versions of
Solaris.

Fixes giampaolo#1002.
@dhduvall dhduvall mentioned this issue Mar 28, 2017
Merged
giampaolo added a commit that referenced this issue Mar 28, 2017
@giampaolo
#1002 give CREDITs for #1002
9009349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug sunos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove use of MA_RESERVED1 from SunOS module dhduvall/psutil
2 participants
@giampaolo @dhduvall