Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] dynamic set buffer size for process connections/fds (fixes #1901) #1903

Merged
merged 13 commits into from
Oct 5, 2021
Merged

[macOS] dynamic set buffer size for process connections/fds (fixes #1901) #1903

merged 13 commits into from
Oct 5, 2021

Conversation

giampaolo
Copy link
Owner

Summary

Description

proc_pidinfo(PROC_PIDLISTFDS) (second call), which is used to list process fds, can fail in case the buffer is not big enough. This PR tries to allocate the buffer dynamically, by calling proc_pidinfo() in a loop, and enlarging the buffer size on each loop.
Before this, a mismatched or "not big enough" buf size, was considered an error which was translated to AccessDenied.

@giampaolo
add psutil_proc_list_fds() utility fun
00f2ff8 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
reuse utility fun
776ecd3 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
rename var
fa7bacb 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
casting
81821e0 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
remove unnecesary (
06e51f7 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo giampaolo mentioned this pull request Jan 7, 2021
Closed
@giampaolo giampaolo changed the title [macOS] dynamic list fds size #1901 [macOS] dynamic buf size for process connections/fds (fixes #1901) Jan 7, 2021
@giampaolo
add debug prints
0476278 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
set a limit for malloc() size
5bf1f8e 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
better debug msg
9bcbcbe 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
OSX: get rid of catch_zombie() ctx mgr
9127f2a 
This was done in order to solve
#1044 and
#1100
...but its logic duplicates the one in wrap_exceptions()
decorator.

Also, this should solve #1901 as it did erroneously translated NSP in
AD.

Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo
adjust error msgs
7fb7ac3 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@ajbozarth ajbozarth mentioned this pull request Jan 22, 2021
Closed
@giampaolo giampaolo changed the title [macOS] dynamic buf size for process connections/fds (fixes #1901) [macOS] dynamic set buffer size for process connections/fds (fixes #1901) Oct 5, 2021
@giampaolo
update comments
10a35e3 
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
@giampaolo giampaolo merged commit e15922b into master Oct 5, 2021
@giampaolo giampaolo deleted the osx-list-fds-refact branch October 5, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MacOS] Race condition in Process.get_connections randomly raises AccessDenied
1 participant
@giampaolo