Add basic NetBSD support. #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw that there is a new release out, but not even feedback on this version. |
|
Hello. Judging from test results this doesn't seem ready for inclusion. What are the major stoppers? SSH access to a NetBSD would be welcome and I can try to take a look. Feel free to contact me privately (g.rodola@gmail.com). |
Closed
|
Sorry for not having given too much attention to this. In case you don't know I added support for OpenBSD in the last psutil release so I would like to push this further. http://grodola.blogspot.com/2015/11/openbsd-support-for-psutil.html explains how I reorganized source files in order to do that. If you're still interested in working on this you should update your PR in accordance, meaning having a shared |
|
Ryo ONODERA has ported psutil to NetBSD, again, based on psutil 3.3.0. I've replaced my version with his and committed it to my fork. Please take a look! Thank you. |
| @@ -123,7 +123,7 @@ | |||
| elif sys.platform.startswith("darwin"): | |||
| from . import _psosx as _psplatform | |||
|
|
|||
| elif sys.platform.startswith("freebsd") or sys.platform.startswith("openbsd"): | |||
| elif sys.platform.startswith("freebsd") or sys.platform.startswith("openbsd") or sys.platform.startswith("netbsd"): | |||
giampaolo
added a commit
that referenced
this pull request
Jan 8, 2016
giampaolo
added a commit
that referenced
this pull request
Jan 8, 2016
|
What's the best way to disable the cwd function on NetBSD? |
|
I just did it in e377b74. It turns out NetBSD has /proc fs (didn't notice). I'm almost done with everything though. I will merge this soon. |
|
That's great news, thank you! |
giampaolo
added a commit
that referenced
this pull request
Jan 8, 2016
giampaolo
added a commit
that referenced
this pull request
Jan 8, 2016
giampaolo
added a commit
that referenced
this pull request
Jan 13, 2016
|
Merged into master. Next version of psutil will support NetBSD (yay!). |
|
Yay! Thank you! I ran the tests again on psutil git head, and this is what I currently see: |
|
I applied different fixes. Can you re-run tests? |
|
Sure, here are the new test results: test_process_create_time fails because my default locale is German. The tests should probably reset to C locale if they compare locale-relevant strings. Thank you for the credits! |
|
Can you retry now? |
|
Sure: |
|
I don't understand why this happens (can't reproduce). Could you try to debug it? The implementation is in |
|
Here's a patch: Can you try it? |
|
The process is long-running and still exists. The file sizes are not relevant, e.g.: Here's the sysctl(8) output for the pid: |
|
With your patch (btw, you need to remove the opening '{' in the first if too) I still get the same error: |
giampaolo
added a commit
that referenced
this pull request
Jan 15, 2016
|
OK can you please try now (337c6be)? |
|
Down to 7! |
|
OK, cool. I think I'm gonna make a release now. These are not important failures and hopefully I/we can fix them later and use this very ticket. for discussing |
|
I'll trust your judgment on that. Let's do it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Klausner tk@giga.or.at
I've updated my one-year old patch.
There are still a lot of test failures. Are these because I didn't implement everything or because there are some major bugs?