Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .debug_line read/write for DWARF 5 #366

Merged
merged 9 commits into from
Jan 29, 2019
Merged

Update .debug_line read/write for DWARF 5 #366

merged 9 commits into from
Jan 29, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jan 28, 2019

Fixes #345

@philipc philipc requested a review from fitzgen January 28, 2019 08:15
@philipc
write/line: inline dirs/files must not be empty
e59bd5a 
Because DWARF version 4 uses these as a terminator.
@coveralls
Copy link

coveralls commented Jan 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 87.396% when pulling e59bd5a on philipc:line-5 into bedf4f0 on gimli-rs:master.

fitzgen
fitzgen approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@philipc philipc merged commit e4d5488 into gimli-rs:master Jan 29, 2019
@philipc philipc deleted the line-5 branch January 29, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philipc @coveralls @fitzgen @bjorn3