Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UninitializedUnwindContext #593

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Oct 7, 2021

Currently UnwindContext and UninitializedUnwindContext::initialize are completely unusable (no function takes UnwindContext as an argument), so there is no need for two types.

Further more, UninitializedUnwindContext is just a boxed UnwindContext; although UnwindContext is large, whether it is boxed or not should be a decision up to the user.

Currently UnwindContext and UninitializedUnwindContext::initialize are
completely unusable (no function takes UnwindContext as an argument), so
just hide them.

UninitializedUnwindContext is removed and whether to box the UnwindContext
or not is left as user decision.
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 373a0fa into gimli-rs:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants