read: improve handling of 0 for tombstones #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
changed the title
philipc
force-pushed
the
tombstone
branch
2 times, most recently
from
67dbf2f
to
f514536
Compare
Where possible, ignore these instead of returning them or returning an error. This often isn't possible because 0 is a valid address, but we can handle it for `DW_LNE_set_address` in the middle of a line sequence, and for address pairs.
|
I've just noticed this PR when I was working on davidlattimore/wild#37. |
|
It's actually only DWARF 6 that will specify this. The issue is https://dwarfstd.org/issues/200609.1.html, and you can also check the draft DWARF 6 standard. lld tried changing to -1 but it broke too many DWARF consumers, so it changed to 0, with a plan to try -1 again sometime in the future. https://reviews.llvm.org/D84825 contains a lot of relevant discussion. |
|
Thank you for the useful pointers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible, ignore these instead of returning them or returning an error. This often isn't possible because 0 is a valid address, but we can handle it for
DW_LNE_set_addressin the middle of a line sequence, and for address pairs.This fixes one of the problems reported in gimli-rs/addr2line#326.