write/coff: Set checksum for BSS section symbols #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am extremely sorry, this is my first time really contributing to such a project.
philipc
requested changes
Aug 11, 2024
|
Added the test now. Since I'm not entirely sure about how section symbols are handled, I decided to add it as the first one before the 2 other symbols. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers generate section symbols for the BSS section, which is then used with relocations in other sections.
This causes a panic on the current version since the checksum is done on
section.data(), which fails the assertion!self.is_bss().With this, I am setting the checksum of a BSS section to 0, which it is also set to with the compiler I am using.