Edit login page test to use page objects

gin · Jun 26, 2020 · 0770b0c · 0770b0c
1 parent 922a866
commit 0770b0c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/test/page-objects/login.page.js b/test/page-objects/login.page.js
@@ -0,0 +1,6 @@
+module.exports = {
+    username: '#username',
+    password: '#password',
+    btnSubmit: 'form button[type="submit"]',
+    banner: '#flash',
+}
diff --git a/test/specs/login.spec.js b/test/specs/login.spec.js
@@ -1,20 +1,21 @@
+const login = require('../page-objects/login.page.js');
+
 describe('the-internet.herokuapp.com login form', () => {
     it('should deny access with wrong creds', () => {
         browser.url('http://the-internet.herokuapp.com/login');
-        $('#username').setValue('test Wrong Name');
-        $('#password').setValue('test Wrong Password');
-        $('form button[type="submit"]').click();
+        $(login.username).setValue('test Wrong Name');
+        $(login.password).setValue('test Wrong Password');
+        $(login.btnSubmit).click();
 
-        expect($('#flash')).toHaveTextContaining('Your username is invalid!');
+        expect($(login.banner)).toHaveTextContaining('Your username is invalid!');
 
     });
     it('should accept access with correct creds', () => {
         browser.url('http://the-internet.herokuapp.com/login');
-        $('#username').setValue('tomsmith');
-        $('#password').setValue('SuperSecretPassword!');
-        $('form button[type="submit"]').click();
+        $(login.username).setValue('tomsmith');
+        $(login.password).setValue('SuperSecretPassword!');
+        $(login.btnSubmit).click();
 
-        expect($('#flash')).toHaveTextContaining('You logged into a secure area!');
+        expect($(login.banner)).toHaveTextContaining('You logged into a secure area!');
     });
 });
-