review updates:

- unused variable - correct return code Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
ginkgo-project · Oct 31, 2023 · c1c4944 · c1c4944
1 parent 2745299
commit c1c4944
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -248,7 +248,6 @@ if(GINKGO_BUILD_MPI)
         ${Ginkgo_SOURCE_DIR}/cmake/openmpi_test.cpp
                 COMPILE_DEFINITIONS -DCHECK_HAS_OPEN_MPI=1
         LINK_LIBRARIES MPI::MPI_CXX
-                OUTPUT_VARIABLE output
         )
     if(uses_openmpi)
         try_compile(valid_openmpi_version

diff --git a/cmake/openmpi_test.cpp b/cmake/openmpi_test.cpp
@@ -40,11 +40,11 @@ int main()
 {
 #if CHECK_HAS_OPEN_MPI && defined(OPEN_MPI) && OPEN_MPI
     static_assert(true);
-#elif CHECK_OPEN_MPI_VERSION
+#elif CHECK_OPEN_MPI_VERSION && defined(OPEN_MPI) && OPEN_MPI
     static_assert(OMPI_MAJOR_VERSION > 4 ||
                   (OMPI_MAJOR_VERSION == 4 && OMPI_MINOR_VERSION >= 1));
 #else
     static_assert(false);
 #endif
-    return 1;
+    return 0;
 }