Merge Fix missing destruction of rand_generator from cuda/hip

This PR fixes the missing destruction of rand_generator from cuda/hip Related PR: #1417
ginkgo-project · Oct 12, 2023 · d3dd178 · d3dd178
2 parents 6b0acfb + c28aeed
commit d3dd178
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/cuda/base/curand_bindings.hpp b/cuda/base/curand_bindings.hpp
@@ -83,6 +83,12 @@ inline curandGenerator_t rand_generator(int64 seed,
 }
 
 
+inline void destroy(curandGenerator_t gen)
+{
+    GKO_ASSERT_NO_CURAND_ERRORS(curandDestroyGenerator(gen));
+}
+
+
 #define GKO_BIND_CURAND_RANDOM_VECTOR(ValueType, CurandName)                 \
     inline void rand_vector(                                                 \
         curandGenerator_t& gen, int n, remove_complex<ValueType> mean,       \

diff --git a/cuda/solver/idr_kernels.cu b/cuda/solver/idr_kernels.cu
@@ -104,6 +104,7 @@ void initialize_subspace_vectors(std::shared_ptr<const DefaultExecutor> exec,
             gen,
             subspace_vectors->get_size()[0] * subspace_vectors->get_stride(),
             0.0, 1.0, subspace_vectors->get_values());
+        curand::destroy(gen);
     }
 }
 

diff --git a/hip/base/hiprand_bindings.hip.hpp b/hip/base/hiprand_bindings.hip.hpp
@@ -87,6 +87,11 @@ inline hiprandGenerator_t rand_generator(int64 seed,
     return gen;
 }
 
+inline void destroy(hiprandGenerator_t gen)
+{
+    GKO_ASSERT_NO_HIPRAND_ERRORS(hiprandDestroyGenerator(gen));
+}
+
 
 #define GKO_BIND_HIPRAND_RANDOM_VECTOR(ValueType, HiprandName)               \
     inline void rand_vector(                                                 \

diff --git a/hip/solver/idr_kernels.hip.cpp b/hip/solver/idr_kernels.hip.cpp
@@ -106,6 +106,7 @@ void initialize_subspace_vectors(std::shared_ptr<const DefaultExecutor> exec,
             gen,
             subspace_vectors->get_size()[0] * subspace_vectors->get_stride(),
             0.0, 1.0, subspace_vectors->get_values());
+        hiprand::destroy(gen);
     }
 }