Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.5.0 to develop #1195

Merged
merged 4 commits into from
Nov 12, 2022
Merged

Release 1.5.0 to develop #1195

merged 4 commits into from
Nov 12, 2022

Conversation

tcojean
Copy link
Member

@tcojean tcojean commented Nov 11, 2022

Add changelog, check updating third-party libraries.

@tcojean tcojean added 1:ST:ready-for-review This PR is ready for review 1:ST:high-importance This issue/PR is of high importance and must be addressed as soon as possible. 1:ST:run-full-test labels Nov 11, 2022
@tcojean tcojean requested a review from a team November 11, 2022 16:22
@tcojean tcojean self-assigned this Nov 11, 2022
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:documentation This is related to documentation. labels Nov 11, 2022
@tcojean tcojean changed the title Release 1.5.0 Release 1.5.0 to develop Nov 11, 2022
@tcojean tcojean requested a review from a team November 11, 2022 16:49
pratikvn
pratikvn approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor and optional suggestions. LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Base: 91.58% // Head: 91.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8773e5b) compared to base (1d12898).
Patch has no changes to coverable lines.

❗ Current head 8773e5b differs from pull request most recent head 3055a94. Consider uploading reports for the commit 3055a94 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1195      +/-   ##
===========================================
- Coverage    91.58%   91.57%   -0.02%     
===========================================
  Files          555      555              
  Lines        47333    47334       +1     
===========================================
- Hits         43352    43348       -4     
- Misses        3981     3986       +5
Impacted Files Coverage Δ
devices/machine_topology.cpp 77.77% <0.00%> (-4.94%) ⬇️
omp/reorder/rcm_kernels.cpp 97.53% <0.00%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

MarcelKoch
MarcelKoch approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
upsj
upsj reviewed Nov 12, 2022
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo and two suggestions :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tcojean and others added 2 commits November 12, 2022 15:39
@tcojean @pratikvn
@MarcelKoch @upsj
Review updates to Changelog
41efd25 
Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
@tcojean
Useless variable expansion
3055a94
@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Nov 12, 2022
@tcojean tcojean merged commit 7c9f530 into develop Nov 12, 2022
@tcojean tcojean deleted the release/1.5.0 branch November 12, 2022 16:02
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj left review comments

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

Assignees

@tcojean tcojean

Labels
1:ST:high-importance This issue/PR is of high importance and must be addressed as soon as possible. 1:ST:ready-to-merge This PR is ready to merge. 1:ST:run-full-test reg:build This is related to the build system. reg:documentation This is related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tcojean @upsj @pratikvn @MarcelKoch @yhmtsai @ginkgo-bot