Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing destruction of rand_generator from cuda/hip #1417

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix missing destruction of rand_generator from cuda/hip #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cuda/base/curand_bindings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ inline curandGenerator_t rand_generator(int64 seed,
}


inline void destroy(curandGenerator_t gen)
{
GKO_ASSERT_NO_CURAND_ERRORS(curandDestroyGenerator(gen));
}


#define GKO_BIND_CURAND_RANDOM_VECTOR(ValueType, CurandName) \
inline void rand_vector( \
curandGenerator_t& gen, int n, remove_complex<ValueType> mean, \
Expand Down
1 change: 1 addition & 0 deletions cuda/solver/idr_kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ void initialize_subspace_vectors(std::shared_ptr<const DefaultExecutor> exec,
gen,
subspace_vectors->get_size()[0] * subspace_vectors->get_stride(),
0.0, 1.0, subspace_vectors->get_values());
curand::destroy(gen);
}
}

Expand Down
5 changes: 5 additions & 0 deletions hip/base/hiprand_bindings.hip.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ inline hiprandGenerator_t rand_generator(int64 seed,
return gen;
}

inline void destroy(hiprandGenerator_t gen)
{
GKO_ASSERT_NO_HIPRAND_ERRORS(hiprandDestroyGenerator(gen));
}


#define GKO_BIND_HIPRAND_RANDOM_VECTOR(ValueType, HiprandName) \
inline void rand_vector( \
Expand Down
1 change: 1 addition & 0 deletions hip/solver/idr_kernels.hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ void initialize_subspace_vectors(std::shared_ptr<const DefaultExecutor> exec,
gen,
subspace_vectors->get_size()[0] * subspace_vectors->get_stride(),
0.0, 1.0, subspace_vectors->get_values());
hiprand::destroy(gen);
}
}

Expand Down