Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pregenerated local solver as factory param #1426

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Add pregenerated local solver as factory param #1426

merged 8 commits into from
Oct 24, 2023

Commits on Oct 23, 2023

  1. Add pregenerated local solver as factory param

    @greole
    greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1fc43ce View commit details
    Browse the repository at this point in the history

  2. Add unit test

    @greole
    greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f6f0169 View commit details
    Browse the repository at this point in the history

  3. Test if generate fails for invalid solver states

    @greole
    greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    174c3c8 View commit details
    Browse the repository at this point in the history

  4. refactor build method a bit, add unit tests

    @greole
    greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5799477 View commit details
    Browse the repository at this point in the history

  5. add missing test

    @greole
    greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c8a4c18 View commit details
    Browse the repository at this point in the history

  6. Implement review comments 

    Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
    @greole @pratikvn
    greole and pratikvn committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    853aa91 View commit details
    Browse the repository at this point in the history

  7. Add review suggestions 

    Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>
    @greole @yhmtsai
    greole and yhmtsai committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b59669d View commit details
    Browse the repository at this point in the history

  8. Format files 

    Co-authored-by: Gregor Olenik <greole@users.noreply.github.com>
    @ginkgo-bot @greole
    ginkgo-bot and greole committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    30c9a7c View commit details
    Browse the repository at this point in the history