Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX/UI : largeur réponsive pour les composants .select2 #4736

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

calummackervoy
Copy link
Contributor

🤔 Pourquoi ?

Une fois qu'un widget select2 est téléchargé (.select2-container--bootstrap-5) la largeur est fixée selon la taille de l'écran :

<span dir="ltr" data-select2-id="3" style="width: 694.667px;" class="select2 select2-container select2-container--bootstrap-5">

Le problème arrive quand on change la taille de l'écran, ces composants sont pas réponsive :

Screenshot 2024-09-12 at 15 01 16

🍰 Comment ?

Dans ce PR je propose une fixe simple où on ajoute une classe qui enforce le composant ne peut pas manger plus de la page que son parent

Screenshot 2024-09-12 at 15 03 08

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

@calummackervoy calummackervoy added the no-changelog Ne doit pas figurer dans le journal des changements. label Sep 12, 2024
@calummackervoy calummackervoy self-assigned this Sep 12, 2024
Copy link
Contributor

@hellodeloo hellodeloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calummackervoy calummackervoy added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit 68d6445 Sep 18, 2024
12 checks passed
@calummackervoy calummackervoy deleted the calum/fix-select2-width branch September 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants