Valider le métier sélectionné dans apply:start #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
added
the
no-changelog
francoisfreitag
force-pushed
the
ff/session
branch
2 times, most recently
from
d6daefc
to
0faaac4
Compare
xavfernandez
approved these changes
Sep 18, 2024
francoisfreitag
force-pushed
the
ff/session
branch
from
0faaac4
to
ef7df0b
Compare
Before this commit, the session could be polluted with invalid data. It turns out the data is only used as initial for the ApplicationJobsForm and gets validated once the form is submitted back, so it does not have practical implications. We should only store validated data in the session.
francoisfreitag
force-pushed
the
ff/session
branch
from
ef7df0b
to
bf5ed79
Compare
francoisfreitag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Avant ce commit, on pouvait mettre de mauvaises données dans la session. Ce n’était pas grave, mais pas terrible non plus.