-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recettes jetables: utilisation de git #4769
Conversation
84c8814
to
76dd35b
Compare
76dd35b
to
f9c0539
Compare
d144691
to
7a4d57a
Compare
7a4d57a
to
ae57055
Compare
ae57055
to
fad7b80
Compare
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
fad7b80
to
2271639
Compare
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 minutes 👏.
Je verrais bien la partie qui remplace la commande deploy
dans un script shell externe, ça éviterais la répétition, ça permettrais de l'utiliser dans create-fast-machine.sh
, et ça serais linté par shellcheck.
$CLEVER_CLI deploy --branch $BRANCH --force | ||
git remote add review_app $($CLEVER_CLI applications --json | jq --raw-output .[0].deploy_url) | ||
git remote -v | ||
GIT_ASKPASS=$(mktemp) && chmod u+rx $GIT_ASKPASS && export GIT_ASKPASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GIT_ASKPASS
🤯
b4845bf
to
7e07ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J’ai toujours un peu espoir qu’une implémentation Python au lieu de bash soit plus lisible et maintenable, mais bon, on peut se dépatouiller du bash.
7e07ab7
to
edc4b3e
Compare
edc4b3e
to
4aa4fe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
4aa4fe6
to
13e8edf
Compare
J'ai rajouté l'option |
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
Et comme discuté avec François, quand le worker GA est en forme, il est capable de git push en 2 minutes: https://github.com/gip-inclusion/les-emplois/actions/runs/10924818541/job/30324809682, parfois avant que Postgresql ne soit dispo et 💥 => Il faudrait donc remettre sur la table la management command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top !
🤔 Pourquoi ?
La création de recettes jetables est très lente.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran