Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistiques : Correction du filtre des structures pour le TB 440 #4772

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rsebille
Copy link
Contributor

@rsebille rsebille commented Sep 18, 2024

🤔 Pourquoi ?

Sinon l'utilisateur ne peux pas choisir une autre de ses structures directement depuis le filtre Metabase.

Se base sur #4775.

@rsebille rsebille added the no-changelog Ne doit pas figurer dans le journal des changements. label Sep 18, 2024
@rsebille rsebille self-assigned this Sep 18, 2024
@rsebille rsebille changed the title Statistiques : Statistiques : Correction du filtre des structures pour la TB 440 Sep 18, 2024
@rsebille rsebille force-pushed the rsebille/tb-440-access-by-membership branch from 721ac07 to d49df86 Compare September 18, 2024 10:18
@rsebille rsebille changed the title Statistiques : Correction du filtre des structures pour la TB 440 Statistiques : Correction du filtre des structures pour le TB 440 Sep 18, 2024
@rsebille rsebille force-pushed the rsebille/tb-440-access-by-membership branch 2 times, most recently from cf79651 to 01fc6ca Compare September 18, 2024 14:03
@rsebille rsebille removed the request for review from xavfernandez September 18, 2024 14:10
@rsebille rsebille force-pushed the rsebille/tb-440-access-by-membership branch from 01fc6ca to 5798814 Compare September 19, 2024 08:29
Copy link
Contributor

@YannickPassa YannickPassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok je vois merci, mais la t'as du changer une tripotée de tests aussi c'est ça ?

@rsebille
Copy link
Contributor Author

Ok je vois merci, mais la t'as du changer une tripotée de tests aussi c'est ça ?

Oui, mais c'est pas directement lié aux besoins et à la modif, le dernier commit est correct même sans les autres c'est juste que j'ai anticipé un problème de N+1 et donc fait un réusinage.

@rsebille rsebille force-pushed the rsebille/tb-440-access-by-membership branch from 5798814 to 1389872 Compare September 19, 2024 10:42
@rsebille rsebille added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 6be04e5 Sep 19, 2024
11 checks passed
@rsebille rsebille deleted the rsebille/tb-440-access-by-membership branch September 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements. pilotage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants