Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating github workflow file to use nuget-acceptable version numbers for packaging #517

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Banashek
Copy link
Contributor

@Banashek Banashek commented Jul 6, 2022

Fixes 513 and should unblock builds.

This change alters the versioning used by github actions for builds by utilizing the Github Run Identifier as an "Additional Label" (in semver parlance) rather than a major version number.

Example (from this failed build)

  • Before: 2564178360 (System.ArgumentException: PackageVersion string specified '2564178360' is invalid.)
  • After: 6.0.0-build.2564178360

This matches the semver logic: Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0. (ref: https://semver.org/)

Copy link
Member

@dustinmoris dustinmoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! I am extremely annoyed that .NET keeps changing shit like this all the time. This was fine in previous .NET Core versions and now they don't accept non-SemVer compatible versions anymore which is why this war broken. Appreciate the fix!

@dustinmoris dustinmoris merged commit 29d18c8 into giraffe-fsharp:develop Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants