Change dev instructions and CI #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd change how they are triggered, so we can control based on the release type: prerelease or release
TheAngryByrd
previously approved these changes
May 4, 2024
nojaf
previously approved these changes
May 5, 2024
|
Great. Let's use the opportunity to move to a |
I like this idea @dbrattli. Previously I was worried about the impact of this change, for example, the documentation at https://giraffe.wiki/. The contents at this site look pretty much what we have on the markdown files from the Please let me know about other potential impacts that you imagine. |
…es by 'main' branch
nojaf
previously approved these changes
May 5, 2024
64J0
changed the title
master -> main and CI
dbrattli
previously approved these changes
May 5, 2024
64J0
changed the title
master -> main and CI
|
Reverted the commits to avoid replacing the |
dbrattli
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm proposing a change in the development process, to stop using the
develop->masterbranch flow, and start using only themasterbranch.masterbranch when they are submitting their PRs.With this in mind, I'm proposing some changes in the README (+ removing the reference to the night builds, since I think they're not running nowadays), DEVGUIDE and the CI workflows.
Related to the CI configuration, I'm separating the build and test workflow, which must work for all PRs and pushes, from the release workflow, which must run only when a new release is created.
Please let me know what you think.
How to test
Related issues