Add F# compatible json serializer #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added some commits to this PR @fpellet, let me know what you think, and feel free to revert them if you dislike it. |
|
It's fine for me 👍 |
pir2o61
reviewed
Jul 29, 2024
There was a problem hiding this comment.
There is also second way - just use the recyclableMemoryStreamManager constant:
new(settings : JsonSerializerSettings) = Serializer(
settings,
Lazy<RecyclableMemoryStreamManager>().Value)
There was a problem hiding this comment.
Do you know if this other approach does provide some improvement compared to the one mentioned at this PR? Just curiosity due to this usage of Lazy<'T> and RecyclableMemoryStreamManager.
There was a problem hiding this comment.
Maybe not important one, but as Lazy<RecyclableMemoryStreamManager>() was the default, it was one argument less in code. :)
Just started using Giraffe and OpenApi and you guys are doing great work with those 🎉 👍
64J0
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add F# compatible json serializer with
FSharp.SystemTextJson:Json.FsharpFriendlySerializerHow to test
Use
Json.FsharpFriendlySerializerRelated issues
#604