Skip to content

Commit

Permalink
installer: allow testing the new page with -d SecurityOptions
Browse files Browse the repository at this point in the history
This lets the user run `installer/release.sh -d SecurityOptions` to see
what the page looks like, even if they do not have Mandatory ASLR
enabled.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Aug 28, 2023
1 parent d519e7c commit 1da1358
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions installer/install.iss
Original file line number Diff line number Diff line change
Expand Up @@ -2352,8 +2352,12 @@ begin
RdbExtraOptions[GP_Symlinks].Checked:=Data<>'Disabled';
#ifdef DEBUG_WIZARD_PAGE
if ('{#DEBUG_WIZARD_PAGE}'='SecurityOptionsPage.ID') then begin
#else
RegQueryBinaryValue(HKEY_LOCAL_MACHINE, 'SYSTEM\CurrentControlSet\Control\Session Manager\kernel', 'MitigationOptions', AslrSetting);
if (AslrSetting[2]=AnsiChar(#01)) then begin
#endif
SecurityOptionsPage:=CreatePage(PrevPageID,'Security options','Add mandatory ASLR security exceptions?',TabOrder,Top,Left);
RdbSecurityOptions[SO_MandatoryASLR]:=CreateCheckBox(SecurityOptionsPage, 'Add mandatory ASLR security exceptions','Add mandatory ASLR security exceptions for the executables in the "usr/bin"'+#13+'directory and Git Bash to function correctly on Windows systems with'+#13+'mandatory ASLR enabled which is a Windows security feature that is'+#13+'disabled by default but appears to be enabled on your system.'+#13++#13+'<RED>WARNING</RED>: If you have installed Git to a path modifiable by an unprivileged user'+#13+'or an external drive this will add mandatory ASLR security exceptions for'+#13+'those paths on which could introduce a security vulnerability!'+#13++#13+'<RED>WARNING</RED>: Doing this significantly slows down the load time of the program'+#13+'settings list in the exploit protection section of the Windows security application'+#13+'but it will load eventually!',TabOrder,Top,Left);
RdbSecurityOptions[SO_MandatoryASLR].Checked:=ReplayChoice('Add mandatory ASLR security exceptions','Auto')='Enabled';
Expand Down

0 comments on commit 1da1358

Please sign in to comment.