Skip to content

Commit

Permalink
installer/portable: include libbrotlienc
Browse files Browse the repository at this point in the history
As of brotli 1.1.0, it seems that the `brotli` executable depends on
that library. And since we include that executable, we need to include
that library, too.

An alternative would be to kick out that executable, as it is _probably_
not required for libcurl to work (which is the only user of brotli in
Git for Windows). But that would be fragile (what if the analysis is
incomplete and the executable _is_ required, in corner cases?) and the
library only weighs ~64 kilobyte anyway, so let's go the robust and easy
route.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Sep 7, 2023
1 parent 0e38d12 commit efbc779
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion make-file-list.sh
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ grep -v -e '\.[acho]$' -e '\.l[ao]$' -e '/aclocal/' \
-e '^/\(mingw\|clang\)[^/]*/itcl/' \
-e '^/\(mingw\|clang\)[^/]*/t\(cl\|k\)[^/]*/\(demos\|msgs\|encoding\|tzdata\)/' \
-e '^/\(mingw\|clang\)[^/]*/bin/\(autopoint\|[a-z]*-config\)$' \
-e '^/\(mingw\|clang\)[^/]*/bin/lib\(asprintf\|brotlienc\|gettext\|gnutls\|gnutlsxx\|gmpxx\|pcre[013-9a-oq-z]\|pcre2-[13p]\|quadmath\|stdc++\|zip\)[^/]*\.dll$' \
-e '^/\(mingw\|clang\)[^/]*/bin/lib\(asprintf\|gettext\|gnutls\|gnutlsxx\|gmpxx\|pcre[013-9a-oq-z]\|pcre2-[13p]\|quadmath\|stdc++\|zip\)[^/]*\.dll$' \
-e '^/\(mingw\|clang\)[^/]*/bin/lib\(atomic\|charset\|gomp\|systre'"$EXCLUDE_LIBSSP"'\)-[0-9]*\.dll$' \
-e '^/\(mingw\|clang\)[^/]*/bin/\(asn1\|gnutls\|idn\|mini\|msg\|nettle\|ngettext\|ocsp\|pcre\|rtmp\|xgettext\|zip\)[^/]*\.exe$' \
-e '^/\(mingw\|clang\)[^/]*/bin/recode-sr-latin.exe$' \
Expand Down

0 comments on commit efbc779

Please sign in to comment.