Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: delete context menu entries created for library folder on uninstall #551

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

nshcr
Copy link
Contributor

@nshcr nshcr commented Apr 1, 2024

A PR(#150) from a long time ago added some context menu entries for the Windows library folder but did not include scripts for their removal, leading to residual registry data after the software was uninstalled.

This PR is intended to address that issue.

…uninstall

Signed-off-by: nshcr <104677079+nshcr@users.noreply.github.com>
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dscho dscho merged commit 7aa0637 into git-for-windows:main Apr 1, 2024
6 checks passed
@dscho
Copy link
Member

dscho commented Apr 1, 2024

/add relnote bug Since v2.14.0(2), Git for Windows' installer registers the Open Git Bash here and Open Git GUI here context menu items also in the special Libraries folders, but the uninstaller never removed them from those folders, which was fixed.

The workflow run was started

github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
Since v2.14.0(2), Git for Windows' installer registers the _Open Git
Bash here_ and _Open Git GUI here_ context menu items also in the
special [Libraries
folders](https://msdn.microsoft.com/en-us/library/windows/desktop/dd758096.aspx),
but the uninstaller never removed them from those folders, [which was
fixed](#551).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants