Let pacman-helper.sh run in Linux
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already define `CURL_CA_BUNDLE`, that should be enough. Besides, it's probably no longer true that `mingw-w64-ca-certificates` lag behind `ca-certificates` in MSYS2 :-) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In POSIX-compliant Unix shells, `$((` starts an arithmetic expression that is ended by `))`. Bash (being... Bash) allows `$((` not only to be an arithmetic expression; It can alternatively be a short form of `$( (`, i.e. the start of a shell expression that is to be executed and then interpolated by its `stdout` where the shell expression immediately starts by opening a subshell. Example: output="$( (cd / && ls -la) | tee >log.txt )" This is valid by the POSIX standard; Removing the space between the two open-parentheses would make it non-standard, where Bash would still run it as intended but Dash, for example, wouldn't. Let's allow executing this script using Dash. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
rimrul
reviewed
Jul 4, 2024
The idea being: We want to be able to run this script in GitHub workflows that use the `ubuntu-latest` pool (because the runners in that pool both start up and run quicker than the ones in the `windows-latest` pool). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
let-pacman-helper-run-in-linux
branch
from
ae824da
to
78ef4e3
Compare
rimrul
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is of course to help git-for-windows/git-for-windows-automation#86