Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e runner container and GHA to build and publish #4860

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Sep 9, 2024

☕️ Reasoning

  • Since we've put Tauri v2 on hold for a bit, I decided to move this e2e testing Dockerfile and the GHA to build and publish it into its own PR here.
  • Backported for Tuari v2 / libwebkitgtk4.0-dev

🧢 Changes

  • Add apps/desktop/e2e/Dockerfile
  • Add GHA to build and publish that Dockerfile (ghcr.io/gitbutlerapp/e2e-runner:latest)
  • Use that e2e-runner:latest image to run the test-e2e.yml GHA

Notes

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:34pm

@mtsgrd
Copy link
Contributor

mtsgrd commented Sep 10, 2024

Nice! Let's ship this?

@ndom91
Copy link
Contributor Author

ndom91 commented Sep 10, 2024

Nice! Let's ship this?

Letting it run through and double checking some things, but yeah if all is well lets do it then!

@ndom91 ndom91 force-pushed the create-prebuilt-e2e-testing-container-and-publish-to-ghcr branch from 4102d4f to b4d876a Compare September 10, 2024 17:08
@ndom91 ndom91 force-pushed the create-prebuilt-e2e-testing-container-and-publish-to-ghcr branch from 7769bcf to 6a0bc0e Compare September 10, 2024 17:09
@ndom91
Copy link
Contributor Author

ndom91 commented Sep 10, 2024

Current open issue: the "E2E Tests" workflow is failing because it's looking for tauri-driver in /github/home/.cargo/bin/tauri-driver apparently, which is weird, it's not like its the normal home directory for a user named github.. 🤔

@ndom91 ndom91 force-pushed the create-prebuilt-e2e-testing-container-and-publish-to-ghcr branch from b472636 to b822d04 Compare September 11, 2024 14:34
@ndom91 ndom91 marked this pull request as ready for review September 11, 2024 15:35
@ndom91
Copy link
Contributor Author

ndom91 commented Sep 11, 2024

@mtsgrd okay this looks like its good to go 👍

@ndom91 ndom91 requested a review from mtsgrd September 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants