Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency in autobuild error tracking #2501

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix inconsistency in autobuild error tracking #2501

merged 1 commit into from
Sep 23, 2024

Conversation

henrymercer
Copy link
Contributor

We decided autobuild errors should be considered configuration errors. This PR fixes a case where some autobuild errors weren't being marked as configuration errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 23, 2024 21:35
angelapwen
angelapwen approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🔬

@henrymercer henrymercer merged commit 07e8133 into main Sep 23, 2024
262 checks passed
@henrymercer henrymercer deleted the henrymercer/missing-autobuild-config-error branch September 23, 2024 21:50
This was referenced Sep 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen