Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: update CODEOWNERS #17461

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rust: update CODEOWNERS #17461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b14b24
Rust: update `CODEOWNERS`
Sep 13, 2024
db9b15d
Merge branch 'main' into redsun82/rust-codeowners
redsun82 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
/java/kotlin-extractor/ @github/codeql-kotlin
/java/ql/test-kotlin1/ @github/codeql-kotlin
/java/ql/test-kotlin2/ @github/codeql-kotlin
/rust/extractor/ @github/codeql-rust-extractor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit overkill to have 3 different sub-teams for a 5 person team ;-) Also the CODEOWNERS viewer complains that the teams do not exist yet. I guess we can start by creating @github/codeql-rust and make that the owner of all the files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: subteams, I got the request to have narrower teams to prevent notification overdrive, see slack. But we can reevaluate.

Re: team not existing, I think I did not follow the playbook from the internal process that should automate this.

/rust/integration-tests/ @github/codeql-rust-extractor
/rust/tools/ @github/codeql-rust-extractor
/rust/ql/test/extractor-tests/ @github/codeql-rust-extractor
/rust/ql/lib/ @github/codeql-rust-library
/rust/ql/test/library-tests/ @github/codeql-rust-library
/rust/ql/src/ @github/codeql-rust-queries
/rust/ql/test/query-tests/ @github/codeql-rust-queries

# CodeQL tools and associated docs
/docs/codeql/codeql-cli/ @github/codeql-cli-reviewers
Expand Down
Loading