-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#/Java: Re-factor the model generator to be a parameterized module. #17509
base: main
Are you sure you want to change the base?
Conversation
12b2877
to
75508d6
Compare
kind = DataFlowImplCommon::getValueReturnPosition(this).getKind() or | ||
kind = DataFlowImplCommon::getParamReturnPosition(this, _).getKind() | ||
} | ||
private import csharp as CS |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
private import CaptureModelsSpecific | ||
private import CaptureModelsPrinting | ||
private import java as J | ||
private import semmle.code.java.dataflow.DataFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
semmle.code.java.dataflow.TaintTracking
private import semmle.code.java.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl | ||
private import semmle.code.java.dataflow.internal.ModelExclusions | ||
private import semmle.code.java.dataflow.internal.TaintTrackingImplSpecific | ||
private import semmle.code.java.dataflow.SSA as Ssa |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
*/ | ||
|
||
private import codeql.dataflow.DataFlow | ||
private import codeql.dataflow.TaintTracking as Tt |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
117287d
to
d09948f
Compare
d09948f
to
faf6fea
Compare
faf6fea
to
f142af5
Compare
DCA looks good! |
In this PR we replace the "pyrameterised" module of the model generator with a parameterised module.
The comments used in the signature module are mostly taken from the C#/Java specific implementation.