Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Database for MySQL #807

Merged
merged 6 commits into from
Dec 17, 2020
Merged

Conversation

elemount
Copy link
Contributor

Related issue: #806

Description

This PR will support gh-ost run on Azure Database for MySQL. Like GCP or Aliyun RDS, Azure Database also need to do some specific things with code modification. This PR including 3 things

  1. Skip port validation for Azure Database for MySQL. It acts as GCP and Aliyun RDS.
  2. Add document for how to use it on Azure Database for MySQL.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@elemount
Copy link
Contributor Author

@shlomi-noach , would you mind to review this PR?

Thanks,
elemount

@timvaillancourt
Copy link
Collaborator

@elemount these changes look good but I don't have cycles to test on Azure

Can you confirm this works in tests on a real Azure database?

@ArtemTrofimushkin
Copy link

Hello, @elemount, @timvaillancourt
Will be this RP merged to main branch?
This fork allows us to apply schema changes on all ours Azure Managed MySQL Database instances.
We use it since (~Dec 2019) and everything works pretty good.

@timvaillancourt timvaillancourt temporarily deployed to production/mysql_role=ghost_testing December 16, 2020 13:03 Inactive
@timvaillancourt timvaillancourt merged commit 8ae02ef into github:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants