Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add tests for spelling #63

Closed
wants to merge 3 commits into from
Closed

WIP: Add tests for spelling #63

wants to merge 3 commits into from

Conversation

bkeepers
Copy link

@bkeepers bkeepers commented Aug 19, 2016

This adds retext-spell to check for spelling. There are currently 200 warnings, mostly from:

@orta
Copy link

orta commented Aug 19, 2016

Nice tooling - we use Danger to offer this kind of feedback inline on my work blog e.g. artsy/artsy.github.io#255

@bkeepers
Copy link
Author

Danger looks awesome.

I stumbled on remark-lint a few weeks ago and was impressed. It's really powerful and configurable, but it's a little involved due to everything operating on a syntax tree (as opposed to using regular expressions).

I don't have a strong preference for tooling, as long as we have thorough tests for the things we care about.

@bkeepers bkeepers mentioned this pull request Aug 30, 2016
@bkeepers bkeepers closed this Oct 18, 2016
@bkeepers bkeepers changed the base branch from gh-pages to master October 18, 2016 20:15
@bkeepers
Copy link
Author

Auto closed when gh-pages branch was deleted in #174

@bkeepers bkeepers reopened this Oct 18, 2016
@bkeepers bkeepers changed the base branch from master to gh-pages November 14, 2016 22:37
* origin/gh-pages: (324 commits)
  Ignore readthedocs.org until fixed
  Fix prose lint errors
  Add description to metadata
  Remove `more` section from template
  add image
  remove more as a field
  remove following as a field
  turn historical vignettes into pull quotes
  simplify open source example
  remove further reading links
  remove further reading links
  doh ok links removed
  remove further reading links
  remove further reading links
  ok actually deleting the links
  remove further reading links
  convert names to github usernames
  remove further reading links
  remove further reading links
  remove further reading links
  ...
@bkeepers
Copy link
Author

@wooorm I was looking at reviving this PR, but there are a ton of really simple words being marked as misspelt. Any idea what is up? Here is just a sampling of the 2961 warnings:

                                                                                                                            retext-spell  retext-spell
    86:120-86:125  warning  `hears` is misspelt                                                                                                                                                                                                                                           retext-spell  retext-spell
    86:138-86:148  warning  `maintainer` is misspelt                                                                                                                                                                                                                                      retext-spell  retext-spell
    86:164-86:175  warning  `discouraged` is misspelt                                                                                                                                                                                                                                     retext-spell  retext-spell
    86:188-86:196  warning  `Research` is misspelt                                                                                                                                                                                                                                        retext-spell  retext-spell
    86:326-86:334  warning  `suggests` is misspelt; did you mean `suggest`?                                                                                                                                                                                                               retext-spell  retext-spell
    86:340-86:350  warning  `maintainer` is misspelt                                                                                                                                                                                                                                      retext-spell  retext-spell
    86:366-86:368  warning  `is` is misspelt; did you mean `id`, `ix`, `s`, `isl`, `ism`, `iv`, `if`, `Io`, `it`, `Ir`, `in`, `Ia`, `ii`, `i`, `PS`, `Ms`, `dis`, `Os`, `As`, `sis`, `SI`, `SS`, `NS`, `US`, `HS`, `BS`, `KS`, `WIS`, `XS`, `IE`, `ISS`, `INS`, `IRS`, `IL`, `IP`, `IQ`?  retext-spell  retext-spell
    86:409-86:422  warning  `contributions` is misspelt                                                                                                                                                                                                                                   retext-spell  retext-spell
      88:10-88:18  warning  `tracking` is misspelt                                                                                                                                                                                                                                        retext-spell  retext-spell
      88:31-88:36  warning  `takes` is misspelt                                                                                                                                                                                                                                           retext-spell  retext-spell
      88:57-88:67  warning  `maintainer` is misspelt                                                                                                                                                                                                                                      retext-spell  retext-spell
      88:83-88:96  warning  `contributions` is misspelt                                                                                                                                                                                                                                   retext-spell  retext-spell
    88:134-88:144  warning  `Responding` is misspelt                                                                                                                                                                                                                                      retext-spell  retext-spell
    88:186-88:188  warning  `as` is misspelt                                                                                                                                                                                                                                              retext-spell  retext-spell
    88:196-88:198  warning  `as` is misspelt                                                                                                                                                                                                                                              retext-spell  retext-spell
    88:209-88:215  warning  `Thanks` is misspelt                                                                                                                                                                                                                                          retext-spell  retext-spell
    88:242-88:248  warning  `review` is misspelt                                                                                                                                                                                                                                          retext-spell  retext-spell
      90:36-90:41  warning  `takes` is misspelt                                                                                                                                                                                                                                           retext-spell  retext-spell
      90:58-90:64  warning  `stages` is misspelt                                                                                                                                                                                                                                          retext-spell  retext-spell
     90:99-90:101  warning  `as` is misspelt                                                                                                                                                                                                                                              retext-spell  retext-spell
    90:134-90:141  warning  `remains` is misspelt                                                                                                                  

@wooorm
Copy link
Contributor

wooorm commented Dec 20, 2016

Really weird. I just checked and it seems to be something wrong with the en-us dictionary: en-gb works fine!

@wooorm
Copy link
Contributor

wooorm commented Dec 20, 2016

Found it. The American-English dictionary contains lots of white-space between columns, whereas other dictionaries use one space. I’ll push a fix to nspell (underlying checker) in a minute.

@wooorm
Copy link
Contributor

wooorm commented Dec 20, 2016

OK, working now. Make sure when updating you the newer nspell is included though.
Also, pushed a commit to pin the retext-spell module as it’s now working and published to npm.

@nayafia
Copy link
Contributor

nayafia commented Jan 31, 2017

@bkeepers still want to merge this?

@sotayamashita
Copy link
Contributor

sotayamashita commented Feb 15, 2017

In Node.js, we use misspell but it is not part of a test. Here is the PR. nodejs/nodejs.org#1130

@bkeepers
Copy link
Author

Thanks for the suggestion @sotayamashita. This project already depends on Ruby and Node. I'm not sure I want to add a Go dependency. I'll look into it, but no promises.

@bkeepers bkeepers added the site label Feb 19, 2017
@bkeepers
Copy link
Author

bkeepers commented Mar 5, 2017

I'd still love to add this, but closing this since I'm not actively working on this.

@bkeepers bkeepers closed this Mar 5, 2017
@bkeepers bkeepers deleted the spell branch March 5, 2017 18:39
@nayafia
Copy link
Contributor

nayafia commented Aug 4, 2017

This was addressed by #431 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants