Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.yml to enable case indentation #143

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

jcmanzo
Copy link
Contributor

@jcmanzo jcmanzo commented Nov 7, 2023

Hello, I noticed that the styleguide suggests a case indentation rule that is not being enforced by the rubocop config. Is it safe to enable this?

@jcmanzo jcmanzo requested a review from a team as a code owner November 7, 2023 17:33
@jcmanzo
Copy link
Contributor Author

jcmanzo commented Dec 4, 2023

Hi @github/rubocop-reviewers 👋

Could I please get some eyes on this change? 🙏 Is this something that would be ok to go out?

@issyl0
Copy link
Member

issyl0 commented Jan 3, 2024

Hey, sorry for the delay here. Thanks for the PR. Looking now!

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

config/default.yml Show resolved Hide resolved
Co-authored-by: Issy Long <issyl0@github.com>
@jcmanzo jcmanzo merged commit 4046c80 into main Jan 3, 2024
8 checks passed
@jcmanzo jcmanzo deleted the jcmanzo-patch-1 branch January 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants