fix: switch colors for disabled inputs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discussable attempt to make disabled inputs more obvious. Recently it seems that the colors had been switched (it looked like input is possible when it was disabled, and vice versa).
The problem is that it looks quite good for dark mode, but a bit too "muted" for light mode right now. The alternative is too make it look quite good for light mode, but then it looks not disabled enough in dark mode.
With this PR (tertiary color for disabled inputs), it looks like this:
Alternative (secondary color for disabled inputs):
Ref glasskube/glasskube#1167