Add support for the useIndianSeparators property (#784)

glennreyes · Mar 11, 2023 · c9c7b31 · c9c7b31
1 parent 6783ad0
commit c9c7b31
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/src/__tests__/CountUp.test.js b/src/__tests__/CountUp.test.js
@@ -136,6 +136,18 @@ describe('CountUp component', () => {
     expect(container).toMatchSnapshot();
   });
 
+  it('renders with useIndianSeparators prop correctly', (done) => {
+    const { container } = render(
+      <CountUp duration={1} end={100000} useIndianSeparators />,
+    );
+
+    setTimeout(() => {
+      const span = container.firstChild;
+      expect(span.textContent).toEqual('1,00,000');
+      done();
+    }, 1200);
+  })
+
   it('renders with delay as a render prop component correctly', () => {
     const { container } = render(
       <CountUp delay={1} end={10}>

diff --git a/src/common.ts b/src/common.ts
@@ -18,6 +18,8 @@ export const createCountUpInstance = (
     start,
     suffix,
     useEasing,
+    useGrouping,
+    useIndianSeparators,
     enableScrollSpy,
     scrollSpyDelay,
     scrollSpyOnce,
@@ -35,7 +37,8 @@ export const createCountUpInstance = (
     prefix,
     suffix,
     useEasing,
-    useGrouping: !!separator,
+    useIndianSeparators,
+    useGrouping,
     enableScrollSpy,
     scrollSpyDelay,
     scrollSpyOnce,

diff --git a/src/useCountUp.ts b/src/useCountUp.ts
@@ -12,14 +12,18 @@ export interface useCountUpProps extends CommonProps, CallbackProps {
 
 const DEFAULTS = {
   decimal: '.',
+  separator: ',',
   delay: null,
   prefix: '',
   suffix: '',
   duration: 2,
   start: 0,
+  decimals: 0,
   startOnMount: true,
   enableReinitialize: true,
   useEasing: true,
+  useGrouping: true,
+  useIndianSeparators: false,
 };
 
 const useCountUp = (props: useCountUpProps): CountUpApi => {