Add types definition #225
Merged
Add types definition #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah that’s great! |
glennreyes
approved these changes
Nov 27, 2019
|
Can someone merge this in since it is approved? was about to submit a DT pr that updates typings (preserveValue is not there right now) |
|
@nelsondude I can update this pr with perverseValue and merge it |
|
@nelsondude it was already added |
|
Thanks, any way you can do a patch version?
…On Wed, Dec 4, 2019 at 2:59 PM Maksim Markelov ***@***.***> wrote:
@nelsondude <https://github.com/nelsondude> it was already added
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225?email_source=notifications&email_token=AF5DN22PQSETEDPGDJHIGG3QXAD2FA5CNFSM4JSKGSHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF6JZMQ#issuecomment-561814706>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5DN2Y3LLUPZABCODMBNODQXAD2FANCNFSM4JSKGSHA>
.
--
Alex Nelson
Software Engineer | Compass
|
|
@nelsondude you can check 4.2.6 version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first step to typescript migration, I suppose adding typings for library would be a good idea.
#109