Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noa material code input #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DennyCai
Copy link

@DennyCai DennyCai commented Aug 5, 2015

I add nineoldandroid library that let it support minimal sdk version 8

compile fileTree(dir: 'libs', include: ['*.jar'])

compile fileTree(include: ['*.jar'], dir: 'libs')
compile 'com.nineoldandroids:library:2.4.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad idea

@DennyCai
Copy link
Author

DennyCai commented Oct 7, 2015

@Shusshu Can you tell me why?

@Shusshu
Copy link

Shusshu commented Oct 7, 2015

Yes it adds a dependency for everyone using this lib even if you don't care about API <11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants